Rename the download-pex-bin scope to pex-cli.
#14344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for uniformity with other tool config scopes, which are named for the tool and not for the act of downloading them. I'd have liked to use just `pex` but that is used to configure pex invocations. While here, standardized terminology in this file, to avoid overloading the term "pex_binary", which is already a target type. [ci skip-rust] [ci skip-build-wheels]
|
Context is to make this slightly less obscure and more uniform: https://pantsbuild.slack.com/archives/C046T6T9U/p1643859620598369 |
stuhood
approved these changes
Feb 3, 2022
kaos
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for uniformity with other tool config scopes, which are named for
the tool and not for the act of downloading them. I'd have liked to use
just
pexbut that is used to configure pex invocations.While here, standardized terminology in this file, to avoid overloading
the term "pex_binary", which is already a target type.
[ci skip-rust]
[ci skip-build-wheels]