Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --fmt-only, --check-only, and --lint-only #14356

Merged
merged 2 commits into from Feb 5, 2022
Merged

Add --fmt-only, --check-only, and --lint-only #14356

merged 2 commits into from Feb 5, 2022

Conversation

Eric-Arellano
Copy link
Contributor

@Eric-Arellano Eric-Arellano commented Feb 4, 2022 •
edited 

❯ ./pants lint --only=isort src/python/pants/util/strutil.py
17:52:30.84 [INFO] Completed: Lint with isort - isort succeeded.

✓ isort succeeded.

❯ ./pants lint --only=fake              
ValueError: Unrecognized name with the option `--lint-only`: 'fake'

All valid names: ['autoflake', 'black', 'docformatter', 'flake8', 'gofmt', 'google-java-format', 'hadolint', 'isort', 'regex-lint', 'scalafmt', 'shellcheck', 'shfmt']


[ci skip-rust]
[ci skip-build-wheels]

@Eric-Arellano
Add --fmt-only, --check-only, and --lint-only
f0b1f47 
[ci skip-rust]

[ci skip-build-wheels]
@Eric-Arellano
Copy link
Contributor Author

We need #14355 before this reaches production.

@Eric-Arellano Eric-Arellano mentioned this pull request Feb 4, 2022
Merged
@Eric-Arellano
Fix bad f string
7c09863 
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano enabled auto-merge (squash) February 5, 2022 01:49
@Eric-Arellano Eric-Arellano merged commit 8ad4945 into pantsbuild:main Feb 5, 2022
@Eric-Arellano Eric-Arellano deleted the lint-only branch February 5, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuhood stuhood stuhood approved these changes

@benjyw benjyw Awaiting requested review from benjyw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Eric-Arellano @stuhood