Tests scala local plugins, and makes it work properly on scala_sources targets
#14512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es` targets # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
added 3 commits
February 16, 2022 12:28
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
…n_tests [ci skip-rust] [ci skip-build-wheels]
stuhood
approved these changes
Feb 16, 2022
stuhood
approved these changes
Feb 16, 2022
| @@ -62,7 +62,7 @@ class Scalac(Subsystem): | |||
| ) | |||
| .advanced() | |||
| .deprecated( | |||
| removal_version="2.12.0dev0", | |||
| removal_version="2.12.0.dev0", | |||
There was a problem hiding this comment.
Oops. Looks like maybe we lost eager validation that these version strings are valid? Not sure if related to the new options system. cc @thejcannon
There was a problem hiding this comment.
I'd be moderately surprised if that were true. The new options system acts as a passthrough, so if you're seeing the removal info when invoking ./pants help ... then the passthrough is working (and the rest of the machinery is firing like before)
tdyas
approved these changes
Feb 16, 2022
…n_tests [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An actual test for the
scalac_pluginsfield (and makes it work properly on generated targets)