Add dynamic help #14543
Merged
Add dynamic help #14543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
|
|
||
|
|
||
| def _eval_maybe_helpt(help: _HelpT, subsystem_cls: Any) -> str: | ||
| return help(subsystem_cls) if inspect.isfunction(help) else help # type: ignore |
There was a problem hiding this comment.
Prefer to use the MyPy error code: https://www.pantsbuild.org/v2.10/docs/style-guide#use-error-codes-in--type-ignore-comments
There was a problem hiding this comment.
Remind me at some point to codify these conventions in a flake8 plugin ;)
There was a problem hiding this comment.
There was a problem hiding this comment.
Those codes are underwhelming. It needs to be beefed up, and in-repo
There was a problem hiding this comment.
Moving this in-repo would be great! That wasn't possible two years ago. But now that we have support for multiple resolves + in-source Flake8 plugins (thanksssss)
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Feb 23, 2022
alonsodomin
pushed a commit
to alonsodomin/pants
that referenced
this pull request
Feb 25, 2022
Adding the ability to "delay" help evaluation until flag options are collected. This mirrors the old behavior and is necessary for "base" subsystems where the help is fully or partially defined in the subclass. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(breakout from #14467)
Adding the ability to "delay" help evaluation until flag options are collected. This mirrors the old behavior and is necessary for "base" subsystems where the help is fully or partially defined in the subclass.
[ci skip-rust]