adds --no-default to Coursier args so that we only use user-configured maven repos (Cherry-pick of #14581) (#14584) #14584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…red maven repos (pantsbuild#14581) Per pantsbuild#14577, `repo1.maven.org` contains a bogus POM for `jai_core`. Coursier's behaviour is to look at its default repos before any user-configured repos, and will download the first POM it finds, regardless of whether it is valid. This means that even if you specify a repo that contains a valid POM, the invalid POM wins out because it is given priority. Further, the `repo1.maven.org` behaviour is opaque, since we have our own `--coursier-repos` option. This PR disables the default repos, so we _only_ use the repos specified by the user. When using `--coursier-repos="['https://repo.osgeo.org/repository/geotools-releases', 'https://maven-central.storage-download.googleapis.com/maven2']"`, Pants is able to resolve `jai_core`. Closes pantsbuild#14577, cc @jvandew. # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
chrisjrn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See-also: #14577
Per #14577,
repo1.maven.orgcontains a bogus POM forjai_core. Coursier's behaviour is to look at its default repos before any user-configured repos, and will download the first POM it finds, regardless of whether it is valid. This means that even if you specify a repo that contains a valid POM, the invalid POM wins out because it is given priority.Further, the
repo1.maven.orgbehaviour is opaque, since we have our own--coursier-reposoption.This PR disables the default repos, so we only use the repos specified by the user.
When using
--coursier-repos="['https://repo.osgeo.org/repository/geotools-releases', 'https://maven-central.storage-download.googleapis.com/maven2']", Pants is able to resolvejai_core.