Move PythonBinary from python.binaries to core.util_rules.system_binaries
#14609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_binaries` # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
benjyw
approved these changes
Feb 24, 2022
alonsodomin
pushed a commit
to alonsodomin/pants
that referenced
this pull request
Feb 25, 2022
…_binaries` (pantsbuild#14609) Builds off of pantsbuild#14601. In a followup, I'll propose moving the remainder of `python.binaries` to a new location. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Feb 27, 2022
…nts.core.util_rules.system_binaries` (#14629) Builds off of #14601 and #14609. Finding binaries on the machine is not foundational to the engine, it's a convenience provided like `ExternalTool` for downloading tools. This gives us a single place for all the binaries we discover, including the types to discover your own. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of #14601.
In a followup, I'll propose moving the remainder of
python.binariesto a new location.[ci skip-rust]
[ci skip-build-wheels]