Add output_path field to pyoxidizer_binary and change its default destination (Cherry-pick of #14607)
#14611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… destination (pantsbuild#14607) Closes pantsbuild#14565. Before: `build/aarch64-apple-darwin/debug/install/bin` After: `src.python/bin/aarch64-apple-darwin/debug/install/bin` As explained on the ticket, we get rid of `build/` because it was noisy. We also need to add a prefix to the directory so that when you have multiple `pyoxidizer_binary` targets, there's no risk of overwriting each other. It's a bummer this causes a longer path, but correctness is more important. We don't mess with PyOxidizer's platform and {debug,release} folders, as considered in pantsbuild#14565. We decided it's too magical and could cause issues for users who want it. [ci skip-rust] [ci skip-build-wheels]
|
The changes to |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
approved these changes
Feb 25, 2022
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14565.
Before:
build/aarch64-apple-darwin/debug/install/binAfter:
src.python/bin/aarch64-apple-darwin/debug/install/binAs explained on the ticket, we get rid of
build/because it was noisy.We also need to add a prefix to the directory so that when you have multiple
pyoxidizer_binarytargets, there's no risk of overwriting each other. It's a bummer this causes a longer path, but correctness is more important.We don't mess with PyOxidizer's platform and {debug,release} folders, as considered in #14565. We decided it's too magical and could cause issues for users who want it.
[ci skip-rust]
[ci skip-build-wheels]