New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Pex to 2.1.65. (Cherry-pick of #14256) #14617
Conversation
This picks up a support for mac universal2 wheels. This support is pressing since cryptography publishes these things and crytography is a library folks tend to have in their transitive dependency set. The intervening changelogs are here: + https://github.com/pantsbuild/pex/releases/tag/v2.1.65 + https://github.com/pantsbuild/pex/releases/tag/v2.1.64 + https://github.com/pantsbuild/pex/releases/tag/v2.1.63 + https://github.com/pantsbuild/pex/releases/tag/v2.1.62 Fixes pantsbuild#14244 (cherry picked from commit 3f5f4d2) [ci skip-rust] [ci skip-build-wheels]
The cherry-pick was not clean in lock files; so I re-generated the 2 relevant ones. The local commit hook showed this as well:
So I had to |
OK, sanity checked, same error in CI: https://github.com/pantsbuild/pants/runs/5335784833?check_suite_focus=true#step:10:328 Digging... |
# "types-freezegun==1.1.6", | ||
# "types-requests==2.27.5", | ||
# "types-setuptools==57.4.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha - these 2 bumps (freezegun & setuptools) trigger the unused type[ignore] warnings. I'll hand roll those fixes into those non-production files instead of altering locks.
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This picks up a support for mac universal2 wheels. This support is
pressing since cryptography publishes these things and crytography is a
library folks tend to have in their transitive dependency set.
The intervening changelogs are here:
Fixes #14244
(cherry picked from commit 3f5f4d2)
[ci skip-rust]
[ci skip-build-wheels]