Fix pyoxidizer_binary to support python_distribution targets that depend on others (Cherry-pick of #14620)
#14626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… depend on others (pantsbuild#14620) It's very common for one `python_distribution` to depend on another, e.g. `pantsbuild.pants.testutil` depends on `pantsbuild.pants`. We can easily support that by having the user specify all necessary `python_distribution` targets in the `dependencies` field. A fancier implementation would calculate for you automatically what dists a `python_distribution` depends on. But that's more complex than it sounds! Note that the dependency is not expressed explicitly via the `dependencies` field, but instead via very complex logic in `setup_py.py`; we'd need to leak that implementation here, or scan the generated `install_requires`. Pants's support for PEP 517 also makes things complicated. So, instead, for now at least, we go with the simple workaround. [ci skip-rust] [ci skip-build-wheels]
stuhood
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's very common for one
python_distributionto depend on another, e.g.pantsbuild.pants.testutildepends onpantsbuild.pants. We can easily support that by having the user specify all necessarypython_distributiontargets in thedependenciesfield.A fancier implementation would calculate for you automatically what dists a
python_distributiondepends on. But that's more complex than it sounds! Note that the dependency is not expressed explicitly via thedependenciesfield, but instead via very complex logic insetup_py.py; we'd need to leak that implementation here, or scan the generatedinstall_requires. Pants's support for PEP 517 also makes things complicated. So, instead, for now at least, we go with the simple workaround.[ci skip-rust]
[ci skip-build-wheels]