Don't show no-op regex-lint output. #14656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before, on a branch with no changes: After: |
Other linters only display output if they acted on at least one file. Previously, we would always show regex-lint output, even in the no-op case of acting on no files. This change brings regex-lint into line with the other linters. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Mar 1, 2022
src/python/pants/core/goals/lint.py
Outdated
Comment on lines
218
to
219
| if request_type.name in specified_names and specs_snapshot.snapshot.files | ||
| ) |
There was a problem hiding this comment.
Peformance nit: you can make this O(1) rather than O(n):
Suggested change
| if request_type.name in specified_names and specs_snapshot.snapshot.files | |
| ) | |
| if request_type.name in specified_names | |
| ) if specs_snapshot.snapshot.files else () |
(Black might not like this formatting, so better to manually apply the fix)
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Mar 1, 2022
Eric-Arellano
pushed a commit
to Eric-Arellano/pants
that referenced
this pull request
Mar 2, 2022
Other linters only display output if they acted on at least one file. Previously, we would always show regex-lint output, even in the no-op case of acting on no files. This change brings regex-lint into line with the other linters. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
added a commit
that referenced
this pull request
Mar 2, 2022
Other linters only display output if they acted on at least one file. Previously, we would always show regex-lint output, even in the no-op case of acting on no files. This change brings regex-lint into line with the other linters. [ci skip-rust] [ci skip-build-wheels] Co-authored-by: Benjy Weinberger <benjyw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other linters only display output if they acted on at least one file.
Previously, we would always show regex-lint output, even in the
no-op case of acting on no files. This change brings regex-lint
into line with the other linters.
[ci skip-rust]
[ci skip-build-wheels]