Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Aegean Check Mark to Multiplication X (Cherry-pick of #14764) #14767

Merged
merged 1 commit into from Mar 12, 2022
Merged

Switch from Aegean Check Mark to Multiplication X (Cherry-pick of #14764) #14767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/python/pants/core/goals/check_test.py
View file
Open in desktop
Expand Up @@ -168,8 +168,8 @@ def test_summary() -> None:
assert stderr == dedent(
"""\

𐄂 ConditionallySucceedsChecker failed.
𐄂 FailingChecker failed.
✕ ConditionallySucceedsChecker failed.
✕ FailingChecker failed.
✓ SuccessfulChecker succeeded.
"""
)
Expand All @@ -180,7 +180,7 @@ def test_summary() -> None:
assert stderr == dedent(
"""\

𐄂 FailingChecker failed.
✕ FailingChecker failed.
✓ SuccessfulChecker succeeded.
"""
)
Expand Down
8 changes: 4 additions & 4 deletions src/python/pants/core/goals/lint_test.py
View file
Open in desktop
Expand Up @@ -219,8 +219,8 @@ def test_summary(rule_runner: RuleRunner, per_file_caching: bool) -> None:
assert stderr == dedent(
"""\

𐄂 ConditionallySucceedsLinter failed.
𐄂 FailingLinter failed.
✕ ConditionallySucceedsLinter failed.
✕ FailingLinter failed.
✓ FilesLinter succeeded.
✓ SuccessfulLinter succeeded.
"""
Expand All @@ -237,7 +237,7 @@ def test_summary(rule_runner: RuleRunner, per_file_caching: bool) -> None:
assert stderr == dedent(
"""\

𐄂 FailingLinter failed.
✕ FailingLinter failed.
✓ FilesLinter succeeded.
"""
)
Expand All @@ -261,7 +261,7 @@ def test_batched(rule_runner: RuleRunner, batch_size: int) -> None:
"""\

✓ ConditionallySucceedsLinter succeeded.
𐄂 FailingLinter failed.
✕ FailingLinter failed.
✓ SuccessfulLinter succeeded.
"""
)
Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/core/goals/test_test.py
View file
Open in desktop
Expand Up @@ -271,7 +271,7 @@ def test_summary(rule_runner: RuleRunner) -> None:
"""\

✓ //:good succeeded in 1.00s (memoized).
𐄂 //:bad failed in 1.00s (memoized).
✕ //:bad failed in 1.00s (memoized).
"""
)

Expand Down
2 changes: 1 addition & 1 deletion src/python/pants/engine/console.py
View file
Open in desktop
Expand Up @@ -86,7 +86,7 @@ def sigil_succeeded_with_edits(self) -> str:

def sigil_failed(self) -> str:
"""Sigil for a failed item."""
return self.red("𐄂")
return self.red("✕")

def sigil_skipped(self) -> str:
"""Sigil for a skipped item."""
Expand Down