Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [python] docs with updates to the resolves feature #14775

Merged
merged 2 commits into from Mar 14, 2022

Conversation

Eric-Arellano
Copy link
Contributor

Some recent changes:

  • We decided to lean into multiple resolves, but hedge that you may need to manually generate locks.
  • Multiple disjoint/overlapping resolves now works! Only isn't super ergonomic without parametrize.

[ci skip-rust]
[ci skip-build-wheels]

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/python/pants/backend/python/subsystems/setup.py Outdated Show resolved Hide resolved
src/python/pants/backend/python/subsystems/setup.py Outdated Show resolved Hide resolved
"`generate-lockfiles` goal and may need to instead manually generate the locks, "
"e.g. by running `pip freeze`. See "
f"{doc_url('python-third-party-dependencies')}.\n\n"
"Categorically, the lockfile cannot be generated by Pants if you need to use VCS "
Copy link
Sponsor Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it should still be in the previous paragraph, because people will already have clicked away to the link by the time they get to this inlined explanation.

src/python/pants/backend/python/subsystems/setup.py Outdated Show resolved Hide resolved
src/python/pants/backend/python/subsystems/setup.py Outdated Show resolved Hide resolved
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano merged commit a037710 into pantsbuild:2.10.x Mar 14, 2022
@Eric-Arellano Eric-Arellano deleted the resolves-docs branch March 14, 2022 21:39
Eric-Arellano added a commit that referenced this pull request Apr 25, 2022
This includes the changes from #14775, which were only applied to 2.10.

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants