Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Clean up load_bytes_with workunit in traces #14777

Merged
merged 2 commits into from
Mar 15, 2022

Conversation

stuhood
Copy link
Sponsor Member

@stuhood stuhood commented Mar 14, 2022

Move the unique identifier from the workunit name into the description (since it's common to group-by workunit name), and drop to trace level.

[ci skip-build-wheels]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood enabled auto-merge (squash) March 14, 2022 21:02
@Eric-Arellano
Copy link
Contributor

Need cherry-pick?

@stuhood
Copy link
Sponsor Member Author

stuhood commented Mar 14, 2022

Need cherry-pick?

Not really: the workunit change that makes debug level more meaningful is only in 2.11.x (#13483).

# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood merged commit 29c609d into pantsbuild:main Mar 15, 2022
@stuhood stuhood deleted the stuhood/cleaner-debug-traces branch March 15, 2022 20:07
dependabot bot added a commit that referenced this pull request Mar 21, 2022
Move the unique identifier from the workunit name into the description (since it's common to group-by workunit name), and drop to `trace` level.

[ci skip-build-wheels]
dependabot bot added a commit that referenced this pull request Mar 27, 2022
Move the unique identifier from the workunit name into the description (since it's common to group-by workunit name), and drop to `trace` level.

[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants