Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go protobuf backend to init/BUILD #14979

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Apr 1, 2022

I forgot to add the Go Protobuf. backend into the init/BUILD so it did not make it into the distribution.

[ci skip-rust]

@tdyas tdyas added needs-cherrypick backend: Go Go backend-related issues labels Apr 1, 2022
@tdyas tdyas added the category:internal CI, fixes for not-yet-released features, etc. label Apr 1, 2022
Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does generate_docs.py need it?

[ci skip-rust]
@tdyas
Copy link
Contributor Author

tdyas commented Apr 1, 2022

does generate_docs.py need it?

Maybe? I wasn't aware of that file. None of the experimental codegen (including Go Protobuf) is listed in that file.

@Eric-Arellano
Copy link
Contributor

we plan to document compiled codegen in 211 right? if so. all those backends should be added. or whichever are ready for public consumption, eg have dep inference

@tdyas tdyas merged commit bc4cd04 into pantsbuild:main Apr 1, 2022
@tdyas tdyas deleted the add_protobuf_go_backend_to_init_build branch April 1, 2022 15:10
tdyas pushed a commit to tdyas/pants that referenced this pull request Apr 1, 2022
I forgot to add the Go Protobuf. backend into the `init/BUILD` so it did not make it into the distribution.

[ci skip-rust]
tdyas pushed a commit that referenced this pull request Apr 1, 2022
I forgot to add the Go Protobuf. backend into the `init/BUILD` so it did not make it into the distribution.

[ci skip-rust]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: Go Go backend-related issues category:internal CI, fixes for not-yet-released features, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants