Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement publish goal for Helm charts #15042

Merged
merged 26 commits into from Apr 14, 2022
Merged

Conversation

alonsodomin
Copy link
Contributor

Now that we have a way of resolving all first and third party dependencies of a Helm chart, the resulting chart package from the package goal is valid enough to be published into registries and consumed elsewhere.

Further improvements will make that the published chart package include a valid Chart.lock file for the third parties that are included in a given helm chart.

Publishing of charts is done via the helm push command and only supports OCI (docker-like) registries.

@alonsodomin
Copy link
Contributor Author

This should wait for #15096 to be merged

@stuhood stuhood requested review from stuhood, Eric-Arellano, tdyas and kaos and removed request for Eric-Arellano April 13, 2022 16:06
Copy link
Contributor

@tdyas tdyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

src/python/pants/backend/helm/goals/publish_test.py Outdated Show resolved Hide resolved
src/python/pants/backend/helm/target_types.py Outdated Show resolved Hide resolved
@stuhood stuhood merged commit 24e3647 into pantsbuild:main Apr 14, 2022
@alonsodomin alonsodomin deleted the helm_publish branch April 18, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants