New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text in angle brackets needs to be escaped for the docsite. #15046
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Presumably the right way to prevent whac-a-mole is to do wholistic HTML escaping in the code that generates these pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Thank you so much for fixing this.
Would be good to cherry pick if you are willing
That would be more robust, yes. I'll leave that as a future todo. |
Oh, it seems that NOT doing html escaping is by design:
As it uses |
Aha. OK then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ick of pantsbuild#15046) [ci skip-rust]
This fixes an issue with the docs, that look like this: