Memoize equality for CoarsenedTarget(s) to avoid exponential runtime in check.
#15277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuhood
changed the title
check.
stuhood
force-pushed
the
stuhood/ct-equals
branch
from
14b0268
to
33058eb
Compare
stuhood
force-pushed
the
stuhood/ct-equals
branch
from
33058eb
to
c15e535
Compare
stuhood
changed the title
check.CoarsenedTarget(s) to avoid exponential runtime in check.
stuhood
commented
Apr 29, 2022
| self._hashcode == other._hashcode | ||
| and self.members == other.members | ||
| # TODO: Use a recursive memoized __eq__ if this ever shows up in profiles. |
There was a problem hiding this comment.
Narrator: "It did."
tdyas
approved these changes
Apr 29, 2022
[ci skip-rust] [ci skip-build-wheels]
stuhood
force-pushed
the
stuhood/ct-equals
branch
from
c15e535
to
a3cab3c
Compare
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Apr 29, 2022
…e in `check`. (pantsbuild#15277) pantsbuild#15141 gave `CoarsenedTarget` new usecases, which unfortunately exposed a case where `check` would re-run in exponential runtime due to not having implemented a TODO about `__eq__` using a memoized graph walk. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#15141 gave
CoarsenedTargetnew usecases, which unfortunately exposed a case wherecheckwould re-run in exponential runtime due to not having implemented a TODO about__eq__using a memoized graph walk.[ci skip-rust]
[ci skip-build-wheels]