BSP resolve filtering observes computed default values of resolve fields #15282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
tdyas
approved these changes
Apr 29, 2022
stuhood
commented
Apr 29, 2022
Comment on lines
+65
to
+72
| TODO: This is to work around the fact that Field value defaulting cannot have arbitrary | ||
| subsystem requirements, and so `JvmResolveField` and `PythonResolveField` have methods | ||
| which compute the true value of the field given a subsytem argument. Consumers need to | ||
| be type aware, and `@rules` cannot have dynamic requirements. | ||
|
|
||
| See https://github.com/pantsbuild/pants/issues/12934 about potentially allowing unions | ||
| (including Field registrations) to have `@rule_helper` methods, which would allow the | ||
| computation of an AsyncFields to directly require a subsystem. |
There was a problem hiding this comment.
IMO, the urgency of this feature has bumped up quite a bit. We need the ability for a @union to represent a full interface, including async methods (@rule_helpers).
Comment on lines
+78
to
+79
| # TODO: Workaround for https://github.com/python/mypy/issues/5485, because we cannot directly use | ||
| # a Callable. |
There was a problem hiding this comment.
This is an unrelated workaround, but it definitely adds insult to injury.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying issue causing us not to have any metadata to merge in #15201 was that the targets in the example were using the default resolve, and the resolve filtering from #15064 was not accounting for default values.
This fixes resolve filtering by adding another union which returns a type which can compute the resolve Field value (using a subsystem in this case).