Fix a bug in the python venv export logic. (cherrypick of #15294) #15307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…15294) Previously, and partly as a legacy of an older implementation, we acted as if the requirements pex had interpreter constraints baked into it. We relied on this when detecting the version of that interpreter. But a requirements pex is internal-only, and so has no interpreter constraints. So in practice we were picking whatever interpreter was used to run the pex, and that may not have been compatible with the relevant constraints. Now we always use a compatible interpreter. [ci skip-rust] [ci skip-build-wheels]
|
Note that this wasn't a clean cherry-pick, as the tool venv export functionality isn't in 2.11.x, so those parts of the original change had to be nuked here. |
Eric-Arellano
approved these changes
May 2, 2022
achimnol
added a commit
to lablup/backend.ai
that referenced
this pull request
May 4, 2022
- pants requires Python 3.7 to 3.9 as its runtime, while the target project may use other Python versions such as Python 3.10. - The reason to use Python 3.10 as the pants runtime was a bug now fixed by pantsbuild/pants#15307.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, and partly as a legacy of an older implementation, we acted as if the requirements pex
had interpreter constraints baked into it. We relied on this when detecting the version of that interpreter.
But a requirements pex is internal-only, and so has no interpreter constraints. So in practice we
were picking whatever interpreter was used to run the pex, and that may not have been compatible
with the relevant constraints.
Now we always use a compatible interpreter.
[ci skip-rust]
[ci skip-build-wheels]