Support the {chroot} env placeholder for all interactive processes that are not executed in the workspace. (Cherry-pick of #15401)
#15405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that are not executed in the workspace. (pantsbuild#15401) # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix #15340 only addressed regular
Processrequests, with the intention of #15341 to leverage the support from therungoal, howeverpublishdoes not use that code path, and thus does not yet have support for the{chroot}placeholder for env values.This PR introduces generic support for the
{chroot}placeholder also forInteractiveProcessrequests that are not to be executed in the workspace. (therungoal executes the interactive processes in the workspace).