Add lint --skip-formatters option

src/python/pants/core/goals/lint.py

@@ -26,13 +26,13 @@
 from pants.engine.rules import Get, MultiGet, collect_rules, goal_rule
 from pants.engine.target import FieldSet, FilteredTargets
 from pants.engine.unions import UnionMembership, union
-from pants.option.option_types import IntOption, StrListOption
+from pants.option.option_types import BoolOption, IntOption, StrListOption
 from pants.util.collections import partition_sequentially
 from pants.util.docutil import bin_name
 from pants.util.logging import LogLevel
 from pants.util.memo import memoized_property
 from pants.util.meta import frozen_after_init
-from pants.util.strutil import strip_v2_chroot_path
+from pants.util.strutil import softwrap, strip_v2_chroot_path
 
 logger = logging.getLogger(__name__)
 
@@ -193,6 +193,18 @@ def activated(cls, union_membership: UnionMembership) -> bool:
         "--only",
         help=only_option_help("lint", "linter", "flake8", "shellcheck"),
     )
+    skip_formatters = BoolOption(
+        "--skip-formatters",
+        default=False,
+        help=softwrap(
+            f"""
+            If true, skip running all formatters in check-only mode.
+
+            FYI: when running `{bin_name()} fmt lint ::`, there should be little performance
+            benefit to using this flag. Pants will reuse the results from `fmt` when running `lint`.
+            """
+        ),
+    )
     batch_size = IntOption(
         "--batch-size",
         advanced=True,
@@ -312,27 +324,29 @@ def batch_by_type(
         request_type(batch) for request_type, batch in batch_by_type(lint_target_request_types)
     )
 
-    batched_fmt_request_pairs = batch_by_type(fmt_target_request_types)
-    all_fmt_source_batches = await MultiGet(
-        Get(
-            SourceFiles,
-            SourceFilesRequest(
-                getattr(field_set, "sources", getattr(field_set, "source", None))
-                for field_set in batch
-            ),
-        )
-        for _, batch in batched_fmt_request_pairs
-    )
-
-    fmt_requests = (
-        request_type(
-            batch,
-            snapshot=source_files_snapshot.snapshot,
+    fmt_requests: Iterable[FmtRequest] = ()
+    if not lint_subsystem.skip_formatters:
+        batched_fmt_request_pairs = batch_by_type(fmt_target_request_types)
+        all_fmt_source_batches = await MultiGet(
+            Get(
+                SourceFiles,
+                SourceFilesRequest(
+                    getattr(field_set, "sources", getattr(field_set, "source", None))
+                    for field_set in batch
+                ),
+            )
+            for _, batch in batched_fmt_request_pairs
         )
-        for (request_type, batch), source_files_snapshot in zip(
-            batched_fmt_request_pairs, all_fmt_source_batches
+        fmt_requests = (
+            request_type(
+                batch,
+                snapshot=source_files_snapshot.snapshot,
+            )
+            for (request_type, batch), source_files_snapshot in zip(
+                batched_fmt_request_pairs, all_fmt_source_batches
+            )
         )
-    )
+
     file_requests = (
         tuple(request_type(specs_snapshot.snapshot.files) for request_type in file_request_types)
         if specs_snapshot.snapshot.files

src/python/pants/core/goals/lint_test.py

@@ -157,11 +157,12 @@ def run_lint_rule(
     rule_runner: RuleRunner,
     *,
     lint_request_types: Sequence[Type[LintTargetsRequest]],
-    fmt_request_types: Sequence[Type[FmtRequest]] = [],
+    fmt_request_types: Sequence[Type[FmtRequest]] = (),
     targets: list[Target],
     run_files_linter: bool = False,
     batch_size: int = 128,
     only: list[str] | None = None,
+    skip_formatters: bool = False,
 ) -> Tuple[int, str]:
     union_membership = UnionMembership(
         {
@@ -174,6 +175,7 @@ def run_lint_rule(
         LintSubsystem,
         batch_size=batch_size,
         only=only or [],
+        skip_formatters=skip_formatters,
     )
     specs_snapshot = SpecsSnapshot(rule_runner.make_snapshot_of_empty_files(["f.txt"]))
     with mock_console(rule_runner.options_bootstrapper) as (console, stdio_reader):
@@ -287,6 +289,24 @@ def test_summary(rule_runner: RuleRunner) -> None:
         """
     )
 
+    exit_code, stderr = run_lint_rule(
+        rule_runner,
+        lint_request_types=lint_request_types,
+        fmt_request_types=fmt_request_types,
+        targets=targets,
+        run_files_linter=True,
+        skip_formatters=True,
+    )
+    assert stderr == dedent(
+        """\
+
+        ✕ ConditionallySucceedsLinter failed.
+        ✕ FailingLinter failed.
+        ✓ FilesLinter succeeded.
+        ✓ SuccessfulLinter succeeded.
+        """
+    )
+
 
 @pytest.mark.parametrize("batch_size", [1, 32, 128, 1024])
 def test_batched(rule_runner: RuleRunner, batch_size: int) -> None: