Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to nails 0.13.0 to pick up support for JDK >=13. #15899

Merged
merged 2 commits into from Jun 22, 2022

Conversation

stuhood
Copy link
Sponsor Member

@stuhood stuhood commented Jun 22, 2022

As described in #14445 and fixed in stuhood/nails#11, JDKs >=13 have slightly different nailgun output. Upgrade to a new release of nails to add support for JDKs >=13.

With this change, JDKs up to zulu-jre:17.0.3 appear to work.

Fixes #14445.

[ci skip-build-wheels]

@stuhood stuhood added needs-cherrypick category:bugfix Bug fixes for released features labels Jun 22, 2022
@stuhood stuhood added this to the 2.12.x milestone Jun 22, 2022
@stuhood stuhood requested review from jsirois and tdyas June 22, 2022 18:30
# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@stuhood stuhood enabled auto-merge (squash) June 22, 2022 18:51
@stuhood stuhood merged commit 55be832 into pantsbuild:main Jun 22, 2022
@stuhood stuhood deleted the stuhood/fix-jdk-13 branch June 22, 2022 19:40
stuhood added a commit to stuhood/pants that referenced this pull request Jun 23, 2022
…build#15899)

As described in pantsbuild#14445 and fixed in stuhood/nails#11, JDKs >=13 have slightly different `nailgun` output. Upgrade to a new release of `nails` to add support for JDKs >=13.

With this change, JDKs up to `zulu-jre:17.0.3` appear to work.

Fixes pantsbuild#14445.

[ci skip-build-wheels]
@stuhood stuhood modified the milestones: 2.12.x, 2.13.x Jun 23, 2022
stuhood added a commit that referenced this pull request Jun 23, 2022
…y-pick of #15899) (#15906)

As described in #14445 and fixed in stuhood/nails#11, JDKs >=13 have slightly different `nailgun` output. Upgrade to a new release of `nails` to add support for JDKs >=13.

With this change, JDKs up to `zulu-jre:17.0.3` appear to work.

Fixes #14445.

[ci skip-build-wheels]
stuhood added a commit to stuhood/pants that referenced this pull request Jun 24, 2022
…build#15899)

As described in pantsbuild#14445 and fixed in stuhood/nails#11, JDKs >=13 have slightly different `nailgun` output. Upgrade to a new release of `nails` to add support for JDKs >=13.

With this change, JDKs up to `zulu-jre:17.0.3` appear to work.

Fixes pantsbuild#14445.

[ci skip-build-wheels]
stuhood added a commit that referenced this pull request Jun 24, 2022
…y-pick of #15899) (#15918)

As described in #14445 and fixed in stuhood/nails#11, JDKs >=13 have slightly different `nailgun` output. Upgrade to a new release of `nails` to add support for JDKs >=13.

With this change, JDKs up to `zulu-jre:17.0.3` appear to work.

Fixes #14445.

[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nailgun servers fail to start with JDKs > 12.
2 participants