Add repository config option to Docker registries. (Cherry pick of #15884) #15952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> [...] using a different docker repository for a given registry? E.g. for registry `A` use `foo` but for registry `B` we want to use `ibm-foo` In order to have different image names between different registries we need a way to provide a registry specific configuration for the image name. This introduces a `repository` config option for registries for this purpose. Example: ```python # BUILD docker_image(repository="foo", registries=["@A", "@b"]) ``` ```toml # pants.toml [docker.registries.A] address = "A" [docker.registries.B] address = "B" repository = "ibm-{target_repository}" ``` # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to have different image names between different registries we need a way to provide a registry specific configuration for the image name. This introduces a
repositoryconfig option for registries for this purpose.Example:
Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]
Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]