Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with __defaults__ not propagating over gaps in the tree of BUILD files. #16089

Merged
merged 3 commits into from Jul 10, 2022

Conversation

kaos
Copy link
Member

@kaos kaos commented Jul 7, 2022

Fix bug introduced in #15836

As reported by @ced-f on Slack:

I have a top level django/BUILD file which contains:

__defaults__({
    (python_tests): dict(dependencies=["django/django_core/settings.py"])
})

And a BUILD file under django/sub/tests/classes/BUILD which just defines:

python_tests(
    name="tests",
)

The dependencies goal in the subdirectory does not reference django/django_core/settings.py
If I extend the contents of django/sub/tests/classes/BUILD the dependency django/django_core/settings.py gets shown correctly:

__defaults__({
    (python_tests): dict(dependencies=["django/django_core/settings.py"])
})
python_tests(
    name="tests",
)

@kaos kaos added the category:bugfix Bug fixes for released features label Jul 7, 2022
Copy link
Sponsor Member

@stuhood stuhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mm, good call. And more parallel too.

kaos added 2 commits July 9, 2022 09:30
[ci skip-rust]

[ci skip-build-wheels]
@kaos kaos merged commit 212271f into pantsbuild:main Jul 10, 2022
@kaos kaos deleted the defaults_bug branch July 10, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:bugfix Bug fixes for released features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants