Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for InteractiveProcess consuming inputs while run_in_workspace=True #16093

Merged
merged 6 commits into from Jul 12, 2022
Merged

Add support for InteractiveProcess consuming inputs while run_in_workspace=True #16093

merged 6 commits into from Jul 12, 2022

Commits on Jul 10, 2022

  1. InteractiveProcess wraps Process. 

    [ci skip-build-wheels]
    @stuhood
    stuhood committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    48d20e0 View commit details
    Browse the repository at this point in the history

  2. InteractiveProcess uses prepare_workdir. 

    [ci skip-build-wheels]
    @stuhood
    stuhood committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    667375c View commit details
    Browse the repository at this point in the history

  3. Use immutable_inputs directly, and deprecate `InteractiveProcessReq… 

    …uest`.

[ci skip-build-wheels]
    @stuhood
    stuhood committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    a5cf7fe View commit details
    Browse the repository at this point in the history

  4. Add native support for optional cleanup of InteractiveProcess tempdirs. 

    [ci skip-build-wheels]
    @stuhood
    stuhood committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    d733d8a View commit details
    Browse the repository at this point in the history

  5. Apply {chroot} templating to args as well. 

    # Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
    @stuhood
    stuhood committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    12f4127 View commit details
    Browse the repository at this point in the history

  6. Remove the restriction on InteractiveProcess inputs, and use native c… 

    …hroots.

[ci skip-rust]
[ci skip-build-wheels]
    @stuhood
    stuhood committed Jul 10, 2022
    Configuration menu
    Copy the full SHA
    8557cd0 View commit details
    Browse the repository at this point in the history