Fix defaulting of parameters in explicitly specified deps on parametrize
d targets for AsyncFieldMixin (Cherry-pick of #16176)
#16179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the tests for #14519 were reasonably good, they tested with
StringField
, rather than additionally withAsyncFieldMixin
. The latter changes the definition of equality for theField
to include its address, meaning that comparing theField
instance itself will never match forField
s from different targets. That made #14519... not particularly useful in production.This change fixes
Field
value comparisons to usefield.value
, references the newly opened #16175 (which is out of scope for now, given that it will likely be impacted by__defaults__
and would be much harder to cherry-pick), and adds an additional test.Fixes #14519.
[ci skip-rust]
[ci skip-build-wheels]