Use filelists to make archive creation tasks more reliable (Cherry-pick of #16183) #16185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d#16183) Previously, creating an archive with a large number of input files would cause the binary to fail due to having a too-long command line. This makes use of `tar`'s `--files-from` option to consume the input filenames from a file, and replaces our direct `zip` invocation with a bash script that provides the input filenames by stdin. There is no practical limit to the length of the file list that can be provided in this way. Closes pantsbuild#16091 # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
stuhood
approved these changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, creating an archive with a large number of input files would cause the binary to fail due to having a too-long command line.
This makes use of
tar's--files-fromoption to consume the input filenames from a file, and replaces our directzipinvocation with a bash script that provides the input filenames by stdin.There is no practical limit to the length of the file list that can be provided in this way.
Closes #16091