jvm: fix fetching artifacts with non-jar packaging #16358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping |
stuhood
reviewed
Aug 2, 2022
src/python/pants/jvm/resolve/coursier_fetch_integration_test.py
Outdated
Show resolved
Hide resolved
stuhood
approved these changes
Aug 2, 2022
alonsodomin
approved these changes
Aug 2, 2022
[ci skip-rust] [ci skip-build-wheels]
Co-authored-by: Stu Hood <stuhood@gmail.com> # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
[ci skip-build-wheels]
tdyas
force-pushed
the
jvm_coursier_nonjar_type
branch
from
e59351b
to
6ff01d7
Compare
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
Fix fetching artifacts that have non-jar packaging, e.g. protoc plugin binaries distributed via Maven Central:
1. Allow coordinate strings used in `JvmToolBase` to provide packaging and classifier items by not limiting the number of `:`-separated fields.
2. Pass `-A` option to Coursier with an explicit list of artifact types ("packaging" in Pants parlance) to retain because Courser only fetches non-jar artifact types if passed this option. This is necessary in addition to also passing the coordinate with the desired artifact type.
[ci skip-rust]
[ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix fetching artifacts that have non-jar packaging, e.g. protoc plugin binaries distributed via Maven Central:
JvmToolBaseto provide packaging and classifier items by not limiting the number of:-separated fields.-Aoption to Coursier with an explicit list of artifact types ("packaging" in Pants parlance) to retain because Courser only fetches non-jar artifact types if passed this option. This is necessary in addition to also passing the coordinate with the desired artifact type.[ci skip-rust]
[ci skip-build-wheels]