Track Python indexes, find-links, and manylinux in lockfile headers #16525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
|
This is the last thing we needed to track in lockfile header, so it's now safe to flip the switch to use v3 with This change is safe even if we continue switching the 3 options to be per-resolve. None of this code will need to change :) |
jsirois
approved these changes
Aug 15, 2022
| @@ -111,14 +120,35 @@ def test_pex_lockfile_generation( | |||
| rule_runner: RuleRunner, no_binary: bool, only_binary: bool | |||
| ) -> None: | |||
| args = ["--python-resolves={'test': 'foo.lock'}"] | |||
| only_binary_lock_str = '// "only_binary": [],\n' | |||
There was a problem hiding this comment.
Do only_binary / no_binary handle name normalization (I suspect not since the metadata types are set[str])? If not there is over-invalidation happening when someone switches from pantsbuild.pants to pantsbuild-pants even though both are the same and do not affect resolves.
There was a problem hiding this comment.
They do not. Good point. I'll fix in a follow up :) #16527
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…antsbuild#16525) Closes pantsbuild#12832. It was a bug that changing `[python-repos].{indexes,repos}` and `[python].resolver_manylinux` did not invalidate lockfiles -- those options could impact the lock result! V2 of lockfile metadata will continue to work the same as before. Next time someone runs `generate-lockfiles` though, they will get the new v3 lockfile header. [ci skip-rust] [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12832. It was a bug that changing
[python-repos].{indexes,repos}and[python].resolver_manylinuxdid not invalidate lockfiles -- those options could impact the lock result!V2 of lockfile metadata will continue to work the same as before. Next time someone runs
generate-lockfilesthough, they will get the new v3 lockfile header.[ci skip-rust]
[ci skip-build-wheels]