Add [python-repos].find_links as preferred alias for [python-repos].repos
#16582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels] [ci skip-rust]
jsirois
approved these changes
Aug 19, 2022
| option, you can either use: | ||
|
|
||
| * a URL to an HTML file with links to wheel and sdist files, or | ||
| * a `file://` absolute path to a local directory with wheel and/or sdist files. |
There was a problem hiding this comment.
I'm almost positive a bare absolute path works too. It does in Pex. Perhaps it complicates docs too much and should just be an easter egg though since it adds 0 capabilities.
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…].repos` (pantsbuild#16582) `find_links` matches the Python ecosystem with pip and Pex. This would have been a better name from the start. At the same time, we are trying to give stronger backward compatibility for users: pantsbuild#16547. It's relatively cheap for us to support both option names ~indefinitely. Note that pantsbuild#15627 took away the ability to give multiple flag names for the same option, which we could have used here. I debated reviving that, but I think this is preferable because it makes clear which option is preferred. Users will get a deprecation message when using `[python-repos].repos`, although they can silence it with `--ignore-warnings`. [ci skip-rust]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_linksmatches the Python ecosystem with pip and Pex. This would have been a better name from the start.At the same time, we are trying to give stronger backward compatibility for users: #16547. It's relatively cheap for us to support both option names ~indefinitely.
Note that #15627 took away the ability to give multiple flag names for the same option, which we could have used here. I debated reviving that, but I think this is preferable because it makes clear which option is preferred. Users will get a deprecation message when using
[python-repos].repos, although they can silence it with--ignore-warnings.[ci skip-build-wheels]