Ensure the sandbox distdir exists when creating dists via PEP517. #16647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a docsite text alignment issue that didn't merit its own change.
stuhood
approved these changes
Aug 25, 2022
|
|
|
PEP 517 does not specify explicitly that the directory must exist, but the example it gives appears to assume that. In any case, there should be no harm in creating it. Setuptools is fine with it and flit requires it. |
benjyw
commented
Aug 25, 2022
| @@ -154,6 +155,7 @@ class DistBuildResult: | |||
| wheel_config_settings = {wheel_config_settings_str} | |||
| sdist_config_settings = {sdist_config_settings_str} | |||
|
|
|||
| os.makedirs(dist_dir, exist_ok=True) | |||
There was a problem hiding this comment.
This is a fresh sandbox each time, so the exist_ok should not be necessary in practice. But it's good to be defensive, in the unlikely event that a directory called dist does exist in the input snapshot for some reason.
Eric-Arellano
approved these changes
Aug 25, 2022
jsirois
approved these changes
Aug 25, 2022
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Aug 26, 2022
…ntsbuild#16647) Also fixes a docsite text alignment issue that didn't merit its own change.
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Aug 26, 2022
…ntsbuild#16647) Also fixes a docsite text alignment issue that didn't merit its own change.
cczona
pushed a commit
to cczona/pants
that referenced
this pull request
Sep 1, 2022
…ntsbuild#16647) Also fixes a docsite text alignment issue that didn't merit its own change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flit, at least, fails if this directory doesn't exist.
Also fixes a docsite text alignment issue that didn't merit its own change.