docker: attempt to fix intermittently uncaptured output #16766
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 2, 2022 17:16
[ci skip-build-wheels]
[ci skip-build-wheels]
This was referenced Sep 3, 2022
tdyas
pushed a commit
that referenced
this pull request
Sep 7, 2022
Capture output from Docker containers once the container has exited. This works-around the issue that #16766 tried to fix when streaming output that the output stream does not close even after the container exits. [ci skip-build-wheels]
|
This PR is now moot given the Docker command runner now uses "executions" to run build actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A WIP non-working attempt to fix #16749 by trying to consume any remaining output from the container's output stream. Times out in tests because Docker does not close the output stream even after the container has exited.