Add an optional speculation delay when using a remote cache (Cherry-pick of #16922) #16956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld#16922) When `nailgun` is combined with a remote cache, cancellation of `nailgun` processes due to cache hits results in `nailgun` servers getting killed (as expected: see pantsbuild#14937 for more on that topic). But the cost of killing a `nailgun` server (which makes _future_ processes run more slowly) is not currently accounted for by our default setting of speculating for all requests. And figuring out the exact likelihood that we will hit the cache is a challenging problem. This change adds an (optional, but enabled by default) delay before starting a `nailgun` process when a remote cache is in use. Fixes pantsbuild#16921. [ci skip-build-wheels]
|
Note that this wasn't a clean pick due to all of the changes to |
Eric-Arellano
approved these changes
Sep 21, 2022
somdoron
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
nailgunis combined with a remote cache, cancellation ofnailgunprocesses due to cache hits results innailgunservers getting killed (as expected: see #14937 for more on that topic).But the cost of killing a
nailgunserver (which makes future processes run more slowly) is not currently accounted for by our default setting of speculating for all requests. And figuring out the exact likelihood that we will hit the cache is a challenging problem.This change adds an (optional, but enabled by default) delay before starting a
nailgunprocess when a remote cache is in use.Fixes #16921.
[ci skip-build-wheels]