Exit normally from K8S parser with unsupported manifests (Cherry-pick of #17037) #17143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…17037) This changes the parser to exit normally (exit_code=0) and without returning any output for those cases # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
stuhood
requested review from
benjyw,
alonsodomin and
jsirois
and removed request for
benjyw
Eric-Arellano
approved these changes
Oct 7, 2022
jsirois
approved these changes
Oct 7, 2022
stuhood
added
category:bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that when having a complex Helm deployment that may contain manifests for CRDs, the Helm backend would render and parse them every time even if the contents of the original template (or the rendered manifest) haven't changed in-between runs.
This is due to the fact that the Helm K8S parser will exit with an
exit_code=2to signal Pants when it has attempted to parse a manifest that it can not understand. This also causes the process cache to not be saved.This changes the parser to exit normally (
exit_code=0) and without returning any output for those cases, so the end result is the same (no container image references found in that given file) but without the re-rendering of those manifest all the time as a side effect.[ci skip-rust]
[ci skip-build-wheels]