Fix bsp-groups.toml example in documentation (Cherry-pick of #17125)
#17148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to: pantsbuild#17122 Example of `bsp-groups.toml` file in documentation could lead to the following problem on MacOs Monterey (python 3.8.6) when running BSP server ``` org.eclipse.lsp4j.jsonrpc.ResponseErrorException: pants.engine.internals.scheduler.ExecutionError: 1 Exception encountered: TomlDecodeError: Key name found without value. Reached end of line. (line 7 column 2 char 190) ``` Fixing `addresses` eliminates this problem # Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
jsirois
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #17122
Example of
bsp-groups.tomlfile in documentation could lead to the following problem on MacOs Monterey (python 3.8.6) when running BSP serverFixing
addresseseliminates this problem. Fixes #17122.