Set PEX_ROOT for export post-processing command. (cherry-pick of #17177) #17200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is both a leak that foils our recommendations to users for maintenance of Pants caches and results in unneeded extra work when an export finds an empty ~/.pex but would have had hits in ~/.cache/pants/named_caches/pex_root if it had been pointed there. Similar to pantsbuild#17177 but not a straight cherry-pick, as it would not apply even remotely cleanly. [ci skip-rust] [ci skip-build-wheels] [ci skip-rust]
Eric-Arellano
approved these changes
Oct 14, 2022
Eric-Arellano
approved these changes
Oct 14, 2022
jsirois
reviewed
Oct 21, 2022
| @@ -143,15 +144,20 @@ async def export_virtualenv( | |||
| "--remove=all", | |||
There was a problem hiding this comment.
This is a busted cherry-pick. 2.14.x goes from rm -rf ~/.pex to rm -rf ~/.cache/pants/named_caches/pex_root since the --remove=all -> --remove=pex bit of the CP was missed.
This explains all of:
There was a problem hiding this comment.
I'm working up a patch to right this...
There was a problem hiding this comment.
Oooof, so I left off the most important bit. Ouch... 🤦 🤦 🤦 🤦 🤦
This was referenced Oct 21, 2022
jsirois
added a commit
to jsirois/pants
that referenced
this pull request
Oct 21, 2022
That cherry-pick was done in pantsbuild#17200 and missed a crucial line which led to `~/.cache/pants/named_caches/pex_root` being nuked on any run of `./pants export` instead of the prior behavior of nuking `~/.pex`. Fixes pantsbuild#17221 [ci skip-rust] [ci skip-build-wheels]
jsirois
added a commit
that referenced
this pull request
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is both a leak that foils our recommendations to users for maintenance of
Pants caches and results in unneeded extra work when an export finds an
empty ~/.pex but would have had hits in ~/.cache/pants/named_caches/pex_root
if it had been pointed there.
A reapplication of part of #17177, but not really a straight cherry-pick, as it would not
apply even remotely cleanly.