Rename SubPartition to Batch in partitioning types.
#17263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been mixing terminology a bit in subsystems that partition inputs.
After this commit, we use terms (more) consistently to mean:
1. "Partition": a set of compatible inputs that _can_ be processed
together, but might not be depending on other settings
2. "Batch": a set of inputs that are actually processed together
thejcannon
reviewed
Oct 19, 2022
thejcannon
reviewed
Oct 19, 2022
|
I think this terminology change is excellent! The linguistic distinction between "Partition" and "Batch" is subtle, but I do think they each convey the nuance you've assigned to them. And it will support an API where those two things are disjoint concerns. E.g., the implementer of a test runner would have to care about how to split into Partitions, but might not have to care about batching - a generic "batch by size" mechanism would work in most/all cases. |
benjyw
approved these changes
Oct 19, 2022
thejcannon
approved these changes
Oct 19, 2022
src/python/pants/backend/codegen/protobuf/lint/buf/lint_rules_integration_test.py
Outdated
Show resolved
Hide resolved
thejcannon
approved these changes
Oct 19, 2022
auto-merge was automatically disabled
October 19, 2022 18:09
Head branch was pushed to by a user without write access
|
Oops, sorry @stuhood looks like I disabled auto-merge with the last push to update docs 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been mixing terminology a bit in subsystems that partition inputs. After this commit, we use terms (more) consistently to mean: