Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the # Dependees column name in the py-constraints summary. #17399

Merged
merged 1 commit into from Oct 31, 2022

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Oct 29, 2022

An option allows you to opt in to the # Dependents name.

Since this is a fairly obscure feature, and we're just changing a column header, so this
will only break things if someone has an automated pipeline that assumes that header,
I feel comfortable with a short deprecation cycle. So this option will switch to True and
be deprecated in 2.16.x, and go away in 2.17.x.

An option allows you to opt in to the `# Dependents` name.

Since this is a fairly obscure feature, I feel comfortable
with a short deprecation cycle. So this option will switch to
True and be deprecated in 2.16.x, and go away in 2.17.x.
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Oct 29, 2022

This is the last of the PRs getting rid of the misleading "dependee" terminology.

Copy link
Contributor

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for respecting the deprecation policy

@benjyw benjyw merged commit 44acec1 into pantsbuild:main Oct 31, 2022
@benjyw benjyw deleted the rename_py_constraints_header branch October 31, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants