Deprecate the old export semantics. #17465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Nov 4, 2022
| warn_or_error( | ||
| "2.23.0.dev0", | ||
| "exporting resolves without using the --resolve option", | ||
| textwrap.dedent( |
There was a problem hiding this comment.
I think softwrap is the universal thing to use now.
There was a problem hiding this comment.
For some reason that didn't look right when rendered. I'll fiddle with it in a future change, doesn't seem worth a CI round.
There was a problem hiding this comment.
Yeah, we use softwrap because it adjusts to the users' terminal size dynamically, e.g. huge 500 character columns. textwrap is instead based on the length of the source code.
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Nov 4, 2022
Employs a long deprecation cycle, since this affects CLI invocations that people may have become used to.
benjyw
added a commit
that referenced
this pull request
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a long deprecation cycle, since this affects CLI invocations that people may have become used to.