support Go data race detector #17510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bike shed for naming the fields: #17517 |
tdyas
force-pushed
the
golang_race_detector
branch
from
227a404
to
0301c43
Compare
Comment on lines
102
to
115
| # Extract the `with_race_detector` value for this target. | ||
| with_race_detector: bool | None = None | ||
| if go_test_subsystem.force_race: | ||
| with_race_detector = True | ||
| if test_target_fields is not None and test_target_fields.test_race.value is not None: | ||
| with_race_detector = test_target_fields.test_race.value | ||
| if with_race_detector is None: | ||
| if target_fields is not None and target_fields.race.value is not None: | ||
| with_race_detector = target_fields.race.value | ||
| if with_race_detector is None: | ||
| if go_mod_target_fields.race is not None: | ||
| with_race_detector = go_mod_target_fields.race.value | ||
| if with_race_detector is None: | ||
| with_race_detector = False |
There was a problem hiding this comment.
This may be valuable to extract into a helper function so that you can unit test. Lots of conditions here
There was a problem hiding this comment.
Also how come not using elif?
There was a problem hiding this comment.
Each of those if with_race_detector is None clauses have an inner if clause that may not be triggered. Thus with_race_detector could continue to be None. elif would have different semantics.
There was a problem hiding this comment.
Simplified the code by introducing a _first_non_none_value helper. Added tests as well of the various combinations.
tdyas
force-pushed
the
golang_race_detector
branch
from
0301c43
to
1c0cbf7
Compare
Eric-Arellano
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the Go data race detector.
Adds a
racefield to thego_modandgo_binarytarget types and atest_racefield to forgo_packagefor tests. The--go-test-force-raceoption will enable the race detector for tests regardless of the fields. The "outermost" relevant field will take effect; that is, aracefield ongo_binarywill override anyracefield on the relevantgo_mod, and with tests atest_racefield on the relevantgo_packagewill override anyracefield on the relevantgo_mod.See https://go.dev/doc/articles/race_detector for additional information about the Go data race detector.
Fixes #17437.