Don't require hardcoded name in python_distribution.provides #17522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It might be provided by a SetupKwargs-generating plugin. Also fix various example uses of the legacy "setup_py()" name to "python_artifact()", which is the name we document.
benjyw
commented
Nov 10, 2022
| @@ -104,6 +86,3 @@ def __eq__(self, other: Any) -> bool: | |||
|
|
|||
| def __hash__(self) -> int: | |||
| return self._hash | |||
|
|
|||
| def __str__(self) -> str: | |||
There was a problem hiding this comment.
I ran all the tests, and manually built some dists, with this __str__ method modified to raise an exception, thus verifying that it's not actually called, let alone does it matter what this stringifies to.
benjyw
commented
Nov 10, 2022
| self._name: str = name | ||
|
|
||
| @property | ||
| def name(self) -> str: |
There was a problem hiding this comment.
I ran all the tests, and manually built some dists, to verify that this property isn't used.
jsirois
approved these changes
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be provided by a SetupKwargs-generating plugin.
Also fix various example uses of the legacy "setup_py()" name to "python_artifact()",
which is the name we document.