Explicitly use "python" ijson backend #17787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijson provides a few backends with varying levels of compatibility and performance; which backend is chosen by ijson is system-dependent. Unfortunately the yajl2 backend does not play nicely with the JSON output by go list and throws an IncompleteJSONError when parsing. As a workaround, we can explicitly use the pure Python backend which is able to parse Go's output correctly.
Eric-Arellano
approved these changes
Dec 13, 2022
Eric-Arellano
added
needs-cherrypick
category:bugfix
tdyas
approved these changes
Dec 13, 2022
|
Thanks for the fix! Looks like mypy is choking on missing type stubs for the backend. Hmm. |
Change this to end in Line 66 in 3ffb10e |
benjyw
reviewed
Dec 13, 2022
Oh, or Eric's suggestion is even better. |
auto-merge was automatically disabled
December 13, 2022 16:39
Head branch was pushed to by a user without write access
benjyw
approved these changes
Dec 13, 2022
|
Thanks @jcrumb-u21 ! I will merge when CI goes green. |
|
There's a test failure in there, but it looks unrelated to me @benjyw |
jcrumb-u21
added a commit
to jcrumb-u21/pants
that referenced
this pull request
Jan 24, 2023
ijson provides a few backends with varying levels of compatibility and performance; which backend is chosen by ijson is system-dependent. Unfortunately the yajl2 backend does not play nicely with the JSON output by go list and throws an IncompleteJSONError when parsing. As a workaround, we can explicitly use the pure Python backend which is able to parse Go's output correctly. Closes pantsbuild#17778
benjyw
pushed a commit
that referenced
this pull request
Jan 24, 2023
ijson provides a few backends with varying levels of compatibility and performance; which backend is chosen by ijson is system-dependent. Unfortunately the yajl2 backend does not play nicely with the JSON output by go list and throws an IncompleteJSONError when parsing. As a workaround, we can explicitly use the pure Python backend which is able to parse Go's output correctly. Closes #17778
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ijson provides a few backends with varying levels of compatibility and performance; which backend is chosen by ijson is system-dependent. Unfortunately the yajl2 backend does not play nicely with the JSON output by go list and throws an IncompleteJSONError when parsing.
As a workaround, we can explicitly use the pure Python backend which is able to parse Go's output correctly.
Closes #17778