Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go: improve options passed to assembler invocations #17796

Merged
merged 1 commit into from Dec 14, 2022
Merged

go: improve options passed to assembler invocations #17796

merged 1 commit into from Dec 14, 2022

Conversation

tdyas
Copy link
Contributor

@tdyas tdyas commented Dec 14, 2022

Make some improvements to invoking the Go assembler in order to conform to what go build does:

  • Add -I option for the source directory.
  • Add -D options to define macros based on GOOS and GOARCH.
  • Copy header files to architecture-independent names. For example, defs_linux_amd64.h becomes defs_GOOS_GOARCH.h.
  • Pass assembler options to gensymabis stage as well.

Fixes #17478.

@tdyas tdyas added backend: Go Go backend-related issues category:bugfix Bug fixes for released features labels Dec 14, 2022
@tdyas tdyas merged commit 29fe3f9 into pantsbuild:main Dec 14, 2022
@tdyas tdyas deleted the golang_assembly_option_improvements branch December 14, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjyw benjyw benjyw approved these changes

@Eric-Arellano Eric-Arellano Awaiting requested review from Eric-Arellano

Assignees
No one assigned
Labels
backend: Go Go backend-related issues category:bugfix Bug fixes for released features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go: copy header files named for current GOOS/GOARCH to standard names
2 participants
@tdyas @benjyw