go: support the go test profiling options
#17836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdyas
commented
Dec 17, 2022
| @@ -540,6 +593,11 @@ async def run_go_tests( | |||
| pkg_target_address=field_set.address, | |||
| ) | |||
|
|
|||
| output_files = [x for x in output_files if x != "cover.out"] | |||
| if output_files: | |||
| # TODO: What is the best way to arrange for these files to be output? | |||
There was a problem hiding this comment.
@benjyw / @Eric-Arellano: The remaining question in this PR is how exactly should ancillary profile files be written to disk?
There was a problem hiding this comment.
(given that the rule returns TestResult). The extra_output attribute does not appear to be used at all to write output out?
There was a problem hiding this comment.
hmm looks like it is written out
pants/src/python/pants/core/goals/test.py
Lines 852 to 855 in 4dc2d02
There was a problem hiding this comment.
Latest commit just has the profiles be extra output from the test run.
tdyas
changed the title
go test profiling optionsgo test profiling options
benjyw
approved these changes
Dec 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the
go testprofiling options which take various profiles of a test run (e.g., CPU, memory, etc.). The profiles are output via theextra_outputfield onTestResult. Also includes the ability to export the compiled test binary (which is needed for analysis of some of the profiles).Closes #16610.