Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix type in check help output #17969

Merged
merged 1 commit into from Jan 12, 2023
Merged

Conversation

ryanking
Copy link
Contributor

Current output of ./pants help-advanced check includes:

 --check-only="['<str>', '<str>', ...]"
  PANTS_CHECK_ONLY
  only
      default: []
      current value: []
      Only run these checkerss and skip all others.

The code
here
adds an 's', so it appears that the source string should be singular.

Current output of `./pants help-advanced check` includes:

```
 --check-only="['<str>', '<str>', ...]"
  PANTS_CHECK_ONLY
  only
      default: []
      current value: []
      Only run these checkerss and skip all others.
```

The [code
here](https://github.com/pantsbuild/pants/blob/63ade26eda1397cff9b731149bace925a63cbb64/src/python/pants/core/goals/multi_tool_goal_helper.py#L34)
adds an 's', so it appears that the source string should be singular.
Copy link
Sponsor Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦
Thanks for the fix!

@ryanking
Copy link
Contributor Author

@benjyw note that I cannot merge this (or restart the flaky CI runs)

@stuhood stuhood enabled auto-merge (squash) January 12, 2023 19:59
@stuhood stuhood merged commit a1989e3 into pantsbuild:main Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants