Allow exporting codegenerated files/resources #18236
Conversation
There was a problem hiding this comment.
I don't recall the motivation for marking these as exportable = False in the first place. Guess it may be due to the files already existing in the repo.. which is still true when not using the http_source which makes me think if there's a nifty way to make this flag swap more cleverly to only be true in case you do use the http_source?
|
Yeah I dunno, but also meh? If someone wants to export a file from in-repo to |
Now with `http_source` which soon will include arbitrary URL handlers, it would be very convenient to simply use `export-codegen` to see the file Pants is using. It'll pull from the cache, which is a plus, and handles auth.
Kind of, I guess.. would be if you run |
|
May God take mercy on anyone who does that 😛 |
Related discussion was held in this PR #13761 |
|
Ah relocated_files makes sense. I like exporting docker files and downloaded artifacts. |
…#18241) Now with `http_source` which soon will include arbitrary URL handlers, it would be very convenient to simply use `export-codegen` to see the file Pants is using. It'll pull from the cache, which is a plus, and handles auth.
|
Why did we cherry-pick this into 2.15.x? In general I don't think a new feature should be cherrypicked when we're trying to stabilize a release. |
|
Welp. I just realized this was introduced in 2.14 and not 2.15. 😓 My bad. |
Now with
http_sourcewhich soon will include arbitrary URL handlers, it would be very convenient to simply useexport-codegento see the file Pants is using. It'll pull from the cache, which is a plus, and handles auth.