Preserve environment variables in pantsd to allow Docker auth.
#18465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
approved these changes
Mar 10, 2023
stuhood
force-pushed
the
stuhood/preserve-docker-environment-variables
branch
from
1017569
to
07edff6
Compare
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 10, 2023
…tsbuild#18465) As reported in pantsbuild#18187, the environment variables used by the `bollard` crate to connect to non-standard Docker setups were being filtered out when `pantsd` was in use. Users confirmed that disabling `pantsd` resolved pantsbuild#18187. This change preserves those environment variables when `pantsd` starts. Fixes pantsbuild#18187.
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 10, 2023
…tsbuild#18465) As reported in pantsbuild#18187, the environment variables used by the `bollard` crate to connect to non-standard Docker setups were being filtered out when `pantsd` was in use. Users confirmed that disabling `pantsd` resolved pantsbuild#18187. This change preserves those environment variables when `pantsd` starts. Fixes pantsbuild#18187.
stuhood
added a commit
that referenced
this pull request
Mar 10, 2023
…rry-pick of #18465) (#18468) As reported in #18187, the environment variables used by the `bollard` crate to connect to non-standard Docker setups were being filtered out when `pantsd` was in use. Users confirmed that disabling `pantsd` resolved #18187. This change preserves those environment variables when `pantsd` starts. Fixes #18187.
stuhood
added a commit
that referenced
this pull request
Mar 10, 2023
…rry-pick of #18465) (#18467) As reported in #18187, the environment variables used by the `bollard` crate to connect to non-standard Docker setups were being filtered out when `pantsd` was in use. Users confirmed that disabling `pantsd` resolved #18187. This change preserves those environment variables when `pantsd` starts. Fixes #18187.
This was referenced Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #18187, the environment variables used by the
bollardcrate to connect to non-standard Docker setups were being filtered out whenpantsdwas in use. Users confirmed that disablingpantsdresolved #18187.This change preserves those environment variables when
pantsdstarts.Fixes #18187.