Let a user resolve shadow a tool lockfile of the same name #18481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame. This is necessary for the transition to named resolves - as the tool name will be an obvious choice for many people for the user resolve. Also, change the name of the synthetic target used for the lockfile. Currently it's squatting on the resolve name, meaning you can't name your python_requirements target for your tool by that name. Now we use a less obtrusive name, that is unlkely to collide with a user-selected one.
|
ping |
cognifloyd
approved these changes
Mar 14, 2023
benjyw
added a commit
to benjyw/pants
that referenced
this pull request
Mar 14, 2023
…d#18481) This is necessary for the transition to named resolves - as the tool name will be an obvious choice for many people for the user resolve. Also, change the name of the synthetic target used for the lockfile. Currently it's squatting on the resolve name, meaning you can't name your python_requirements target for your tool by that name. Now we use a less obtrusive name, that is unlkely to collide with a user-selected one.
benjyw
added a commit
that referenced
this pull request
Mar 14, 2023
…ck of #18481) (#18493) This is necessary for the transition to named resolves - as the tool name will be an obvious choice for many people for the user resolve. Also, change the name of the synthetic target used for the lockfile. Currently it's squatting on the resolve name, meaning you can't name your python_requirements target for your tool by that name. Now we use a less obtrusive name, that is unlkely to collide with a user-selected one.
This was referenced Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for the transition to named resolves - as the tool name will be an obvious choice for many people for the user resolve.
Also, change the name of the synthetic target used for the lockfile. Currently it's squatting on the resolve name, meaning you can't name your python_requirements target for your tool by that name. Now we use a less obtrusive name, that is unlkely to collide with a user-selected one.