Add support for Docker registry auth #18541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsirois
approved these changes
Mar 21, 2023
…iables needed by credential helpers.
stuhood
force-pushed
the
stuhood/docker-credentials
branch
from
fb3435a
to
76d568c
Compare
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 22, 2023
As reported in pantsbuild#18533, the `bollard` crate does not implement Docker registry auth. The `docker_credential` crate does though (including invoking [credential helpers](https://docs.docker.com/engine/reference/commandline/login/#credential-helper-protocol) if necessary). This change was tested to suffice for auth against AWS ECR registries (which use the `docker-credential-ecr-login` helper). Fixes pantsbuild#18533.
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 22, 2023
As reported in pantsbuild#18533, the `bollard` crate does not implement Docker registry auth. The `docker_credential` crate does though (including invoking [credential helpers](https://docs.docker.com/engine/reference/commandline/login/#credential-helper-protocol) if necessary). This change was tested to suffice for auth against AWS ECR registries (which use the `docker-credential-ecr-login` helper). Fixes pantsbuild#18533.
stuhood
added a commit
that referenced
this pull request
Mar 22, 2023
As reported in #18533, the `bollard` crate does not implement Docker registry auth. The `docker_credential` crate does though (including invoking [credential helpers](https://docs.docker.com/engine/reference/commandline/login/#credential-helper-protocol) if necessary). This change was tested to suffice for auth against AWS ECR registries (which use the `docker-credential-ecr-login` helper). Fixes #18533.
stuhood
added a commit
that referenced
this pull request
Mar 22, 2023
As reported in #18533, the `bollard` crate does not implement Docker registry auth. The `docker_credential` crate does though (including invoking [credential helpers](https://docs.docker.com/engine/reference/commandline/login/#credential-helper-protocol) if necessary). This change was tested to suffice for auth against AWS ECR registries (which use the `docker-credential-ecr-login` helper). Fixes #18533.
This was referenced Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #18533, the
bollardcrate does not implement Docker registry auth. Thedocker_credentialcrate does though (including invoking credential helpers if necessary).This change was tested to suffice for auth against AWS ECR registries (which use the
docker-credential-ecr-loginhelper).Fixes #18533.