Fail fast for attempts to use test --debug with a docker environment
#18560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`s (until pantsbuild#17182 is implemented).
benjyw
approved these changes
Mar 23, 2023
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 23, 2023
pantsbuild#18560) As described in pantsbuild#18212, `test --debug` currently silently uses the local environment to attempt to debug a target, which can cause a lot of confusion. Other goals like `run` at least render a warning. Until pantsbuild#17182 is fixed, we should ensure that we fail fast for the case of `test --debug` instead. Fixes pantsbuild#18212.
stuhood
added a commit
to stuhood/pants
that referenced
this pull request
Mar 23, 2023
pantsbuild#18560) As described in pantsbuild#18212, `test --debug` currently silently uses the local environment to attempt to debug a target, which can cause a lot of confusion. Other goals like `run` at least render a warning. Until pantsbuild#17182 is fixed, we should ensure that we fail fast for the case of `test --debug` instead. Fixes pantsbuild#18212.
stuhood
added a commit
that referenced
this pull request
Mar 23, 2023
…t (Cherry-pick of #18560) (#18567) As described in #18212, `test --debug` currently silently uses the local environment to attempt to debug a target, which can cause a lot of confusion. Other goals like `run` at least render a warning. Until #17182 is fixed, we should ensure that we fail fast for the case of `test --debug` instead. Fixes #18212.
stuhood
added a commit
that referenced
this pull request
Mar 23, 2023
…t (Cherry-pick of #18560) (#18568) As described in #18212, `test --debug` currently silently uses the local environment to attempt to debug a target, which can cause a lot of confusion. Other goals like `run` at least render a warning. Until #17182 is fixed, we should ensure that we fail fast for the case of `test --debug` instead. Fixes #18212.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #18212,
test --debugcurrently silently uses the local environment to attempt to debug a target, which can cause a lot of confusion. Other goals likerunat least render a warning.Until #17182 is fixed, we should ensure that we fail fast for the case of
test --debuginstead.Fixes #18212.